[PATCH] D34441: [clang-format] Support text proto messages

This revision was automatically updated to reflect the committed changes. Closed by commit rL307029: [clang-format] Support text proto messages (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D34441 Files: cfe/trunk/include/clang/Format/Format.h cfe/trunk/lib/Format/C

[PATCH] D34441: [clang-format] Support text proto messages

krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:107 + if (Style.Language == FormatStyle::LK_TextProto) { +State.Stack.back().AvoidBinPacking = true; djasper wrote: > Do we need to set this explicitly here? Is it not enough t

[PATCH] D34441: [clang-format] Support text proto messages

krasimir updated this revision to Diff 105044. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D34441 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/FormatT

[PATCH] D34441: [clang-format] Support text proto messages

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:71 + const FormatStyle &Style) { + assert(LessTok.is(tok::less)); + return Style.Language == FormatStyle::LK_TextProto || Maybe rename to opensP

[PATCH] D34441: [clang-format] Support text proto messages

krasimir added a comment. @djasper: I think this is ready for review. https://reviews.llvm.org/D34441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34441: [clang-format] Support text proto messages

krasimir updated this revision to Diff 104646. krasimir added a comment. - Wrap-up this patch https://reviews.llvm.org/D34441 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp lib/For

[PATCH] D34441: [clang-format] Support text proto messages

krasimir updated this revision to Diff 104645. krasimir added a comment. - Add initial support for <>-style message fields - Added single-line tests - Added multiline message proto tests https://reviews.llvm.org/D34441 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp

[PATCH] D34441: [clang-format] Support text proto messages

krasimir added a comment. Tests for `<>`-style message fields are missing because I discovered that they don't really work in a multiline setting in proto options anyways. I'll address this problem separately. https://reviews.llvm.org/D34441 ___ c

[PATCH] D34441: [clang-format] Support text proto messages

krasimir updated this revision to Diff 103352. krasimir added a comment. - Remove newline https://reviews.llvm.org/D34441 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp l