[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

2017-06-27 Thread Peter Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306385: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc (authored by psmith). Changed prior to commit: https://reviews.llvm.org/D34513?vs=103570&id=104116#toc Repository: rL LLVM

[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

2017-06-23 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Looks like a pretty mechanical change. https://reviews.llvm.org/D34513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

2017-06-22 Thread Christof Douma via Phabricator via cfe-commits
christof added a reviewer: alexfh. christof added a comment. Added Alexander as he seems to have touched clang-tidy recently. https://reviews.llvm.org/D34513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

2017-06-22 Thread Christof Douma via Phabricator via cfe-commits
christof added a comment. This looks good to me. But since I have never touch this code, I'll wait a bit till accepting this for others to have a say. https://reviews.llvm.org/D34513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

2017-06-22 Thread Peter Smith via Phabricator via cfe-commits
peter.smith created this revision. https://reviews.llvm.org/D31709 [NFC] Refactor DiagnosticRenderer to use FullSourceLoc was committed in r305684 and reverted in 305688 as clang-tidy and clang-query failed to build. This change updates the extra tools to use the new interface. With this chang