[PATCH] D34568: [Sema] Make BreakContinueFinder handle nested loops.

2017-07-03 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307051: [Sema] Make BreakContinueFinder handle nested loops. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D34568?vs=103761=105128#toc Repository: rL LLVM

[PATCH] D34568: [Sema] Make BreakContinueFinder handle nested loops.

2017-06-30 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! I'm not particularly happy with the number of different places where we duplicate the knowledge of how break/continue bind to enclosing loops, but fixing that seems beyond the

[PATCH] D34568: [Sema] Make BreakContinueFinder handle nested loops.

2017-06-30 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D34568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34568: [Sema] Make BreakContinueFinder handle nested loops.

2017-06-23 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. We don't care about break or continue statements that aren't associated with the current loop, so make sure the visitor doesn't find them. Fixes https://bugs.llvm.org/show_bug.cgi?id=32648 . Repository: rL LLVM https://reviews.llvm.org/D34568 Files: