[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

This revision was automatically updated to reflect the committed changes. Closed by commit rL307172: Address comments that escaped D3 (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D34671?vs=104966=105284#toc Repository: rL LLVM

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

jyu2 updated this revision to Diff 104966. jyu2 added a comment. Hi Richard, Thank you so much for your review. I just update patch to address you new comment. Please let me know if you see more problems. Thanks. Jennifer Repository: rL LLVM https://reviews.llvm.org/D34671 Files:

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

rsmith added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:409 +<< (Ty->hasExceptionSpec() ? FD->getExceptionSpecSourceRange() + : FD->getSourceRange()); +} else Underlining the entire

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

jyu2 updated this revision to Diff 104959. jyu2 added a comment. Hi Aaron, Thank you so much for your review. I just update change to address your comments. Let me kwon if you see more problems. Thanks again. Jennifer Repository: rL LLVM https://reviews.llvm.org/D34671 Files:

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

jyu2 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6356-6357 +: Warning< + "%0 has a non-throwing exception specification but can " "still " + "throw">, +

[PATCH] D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6356-6357 +: Warning< + "%0 has a non-throwing exception specification but can " "still " + "throw">, +