sylvestre.ledru reopened this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.
actually, arc commit never landed this change :(
https://reviews.llvm.org/D34824
___
cfe-commits mailing list
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Yeah, improving the testsuite generally seems like a good idea. But unrelated
to this patch. This looks good now.
https://reviews.llvm.org/D34824
sylvestre.ledru updated this revision to Diff 107089.
sylvestre.ledru marked an inline comment as done.
sylvestre.ledru added a comment.
Fixed, thanks for spotting the mistake.
Looks like we could improve the testsuite as my mistake hasn't been catched.
https://reviews.llvm.org/D34824
Files:
djasper added inline comments.
Comment at: tools/clang-format/ClangFormat.cpp:377
break;
case 1:
Error = clang::format::format(FileNames[0]);
sylvestre.ledru wrote:
> djasper wrote:
> > I think we should restructure the code to not have to duplicate
sylvestre.ledru marked 7 inline comments as done.
sylvestre.ledru added inline comments.
Comment at: test/Format/verbose.cpp:2
+// RUN: clang-format %s -verbose | FileCheck %s
+// CHECK: Formatting
+
djasper wrote:
> This seems like a pretty minimal test to me.
sylvestre.ledru updated this revision to Diff 106778.
https://reviews.llvm.org/D34824
Files:
docs/ClangFormat.rst
docs/ReleaseNotes.rst
test/Format/verbose.cpp
tools/clang-format/ClangFormat.cpp
Index: tools/clang-format/ClangFormat.cpp
sylvestre.ledru added inline comments.
Comment at: tools/clang-format/ClangFormat.cpp:377
break;
case 1:
Error = clang::format::format(FileNames[0]);
djasper wrote:
> I think we should restructure the code to not have to duplicate what you are
>
djasper added a comment.
Generally upload diffs with full context to phabricator. That makes reviewing
much easier.
Comment at: test/Format/verbose.cpp:2
+// RUN: clang-format %s -verbose | FileCheck %s
+// CHECK: Formatting
+
This seems like a pretty minimal
sylvestre.ledru added a comment.
is that ok @djasper ?
https://reviews.llvm.org/D34824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru added inline comments.
Comment at: tools/clang-format/ClangFormat.cpp:380
+if (Verbose.getNumOccurrences() != 0)
+outs() << "Formatting " << FileNames[0] << '\n';
break;
djasper wrote:
> As clang-format often returns the result
sylvestre.ledru updated this revision to Diff 104995.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D34824
Files:
docs/ClangFormat.rst
docs/ReleaseNotes.rst
test/Format/verbose.cpp
tools/clang-format/ClangFormat.cpp
Index: tools/clang-format/ClangFormat.cpp
djasper added a comment.
Can you add a test? Tests for this kind of behavior of the clang-format command
line go in test/Format/.
Comment at: tools/clang-format/ClangFormat.cpp:380
+if (Verbose.getNumOccurrences() != 0)
+outs() << "Formatting " << FileNames[0] <<
sylvestre.ledru created this revision.
sylvestre.ledru added a project: clang.
https://reviews.llvm.org/D34824
Files:
docs/ClangFormat.rst
docs/ReleaseNotes.rst
tools/clang-format/ClangFormat.cpp
Index: docs/ReleaseNotes.rst
13 matches
Mail list logo
