This revision was automatically updated to reflect the committed changes.
Closed by commit rL307898: [refactor][rename] Use a single base class for class
that finds (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D34949?vs=105084&id=106388#toc
Repository:
rL LLVM
h
hokein accepted this revision.
hokein added a comment.
LGTM.
Comment at: include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h:33
+: public RecursiveASTVisitor> {
+ using BaseType = RecursiveASTVisitor>;
+ const SourceManager &SM;
nit: I'd add a `pri
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rL LLVM
https://reviews.llvm.org/D34949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D34949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 105084.
arphaman added a comment.
Small fixup.
Repository:
rL LLVM
https://reviews.llvm.org/D34949
Files:
include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h
include/clang/Tooling/Refactoring/Rename/USRFinder.h
include/clang/module.modulema
arphaman added a comment.
This is meant to be NFC btw.
Repository:
rL LLVM
https://reviews.llvm.org/D34949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
- Use single `RecursiveSymbolVisitor` class for both `USRLocFindingASTVisitor`
and `NamedDeclOccurrenceFindingVisitor` to avoid duplicate visiting code.
- Traverse nested name specifier locs in the new class and remove the separate
matching step.
- New class `Name
