[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

This revision was automatically updated to reflect the committed changes. Closed by commit rC327528: Expand clang-interpreter with example of throwing in and from the JIT for… (authored by marsupial, committed by ). Repository: rC Clang https://reviews.llvm.org/D35103 Files:

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

martell added a comment. Herald added a subscriber: mgrang. ping @marsupial https://reviews.llvm.org/D35103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial marked 3 inline comments as done. marsupial added a comment. Done, thanks. Would it be possible to look at https://reviews.llvm.org/D30709 as this depends on that. (ELF does not like Windows exceptions). https://reviews.llvm.org/D35103

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial updated this revision to Diff 108676. marsupial added a comment. Use include guards, not pragma once and remove commented CMake debug lines. https://reviews.llvm.org/D35103 Files: examples/clang-interpreter/CMakeLists.txt examples/clang-interpreter/Invoke.cpp

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Otherwise this looks good to me. Comment at: examples/clang-interpreter/CMakeLists.txt:73 +set_property(TARGET ${TARGET} PROPERTY COMPILE_FLAGS ${editedFlags}) +

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial added a comment. Ping. https://reviews.llvm.org/D35103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial marked 3 inline comments as done. marsupial added a comment. Done, and changed to 'windows.h', but blocked mingw from even attempting SEH for now. https://reviews.llvm.org/D35103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial updated this revision to Diff 106548. marsupial added a comment. Blocked Win64 SEH for MingW entirely. Theoretically it should be possible to throw a SEH from within mingw, but but I'm thinking clang may be generating exception handlers for the gcc runtime in that case. I'll leave it

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

martell added inline comments. Comment at: examples/clang-interpreter/Manager.cpp:18 +#define NOMINMAX +#include +#endif windows.h with lower case `w` to not break mingw https://reviews.llvm.org/D35103 ___

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

martell added a comment. Just 2 small nits. Comment at: examples/clang-interpreter/main.cpp:165 + llvm::errs() << "'main' function not found in module.\n"; + return 255; +} 255 -> Res ? Comment at:

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial created this revision. Herald added a subscriber: mgorny. Getting this to work is not particularly obvious, and having it as an example should be helpful. Portions of this could be placed into LLVM, but as a whole it seems necessary to do this a higher level.