This revision was automatically updated to reflect the committed changes.
Closed by commit rL308678: [clang-tools-extra] Add support for plain C structs
in clang-reorder-fields (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D35329?vs=107143=107588#toc
Repository:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D35329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexshap updated this revision to Diff 107143.
alexshap added a comment.
update the comments
Repository:
rL LLVM
https://reviews.llvm.org/D35329
Files:
clang-reorder-fields/ReorderFieldsAction.cpp
test/clang-reorder-fields/PlainCStructFieldsOrder.c
Index:
hokein added inline comments.
Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:236
+
+// CXXRD will be nullptr if C code (not C++) is being processed
+const CXXRecordDecl *CXXRD = dyn_cast(RD);
Nit: missing a trailing `.`.
I think we could use
alexshap added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D35329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap created this revision.
This diff adds support for reordering fields in structs when the code compiles
as plain C,
in particular we switch to using RecordDecl instead of CXXRecordDecl where it's
appropriate.
Test plan: make check-all
Repository:
rL LLVM
