[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-22 Thread Erik Verbruggen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL311442: Fix templated type alias completion when using global completion cache (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D35355?vs=109968=112144#toc Repository: rL LLVM

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-18 Thread Erik Verbruggen via Phabricator via cfe-commits
erikjv added a comment. I'll commit it, probably next Tuesday. https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-14 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. Can someone help me to commit it to the proper branch? (I don't have permissions) https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-09 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-08 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. Ping... https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-07 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan updated this revision to Diff 109968. yvvan added a comment. Add unit-test for the case fixed in this review https://reviews.llvm.org/D35355 Files: lib/Frontend/ASTUnit.cpp lib/Parse/ParseTemplate.cpp test/Index/code-completion.cpp Index: test/Index/code-completion.cpp

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-04 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. In https://reviews.llvm.org/D35355#831845, @klimek wrote: > Sorry for missing this - can you add a test? I think I can :) Will add it next week. https://reviews.llvm.org/D35355 ___ cfe-commits mailing list

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-04 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added a comment. Sorry for missing this - can you add a test? https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-08-04 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. one more Ping. this is quite a useful fix that does not cost much https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-07-18 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. Ping https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

2017-07-13 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan created this revision. When we have enabled cache for global completions we did not have diagnostics for Bar and could not complete Ba as in provided code example. template struct Foo { T member; }; template using Bar = Foo; int main() { Ba } https://reviews.llvm.org/D35355