[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310863: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module. (authored by chh). Changed prior to commit: https://reviews.llvm.org/D35368?vs=110750=111033#toc Repository: rL

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

hokein accepted this revision. hokein added a comment. LGTM https://reviews.llvm.org/D35368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

yawanng updated this revision to Diff 110750. yawanng marked 2 inline comments as done. https://reviews.llvm.org/D35368 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecInotifyInit1Check.cpp

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

hokein added inline comments. Comment at: clang-tidy/android/CloexecInotifyInit1Check.cpp:28 +void CloexecInotifyInit1Check::check(const MatchFinder::MatchResult ) { + insertMacroFlag(Result, "IN_CLOEXEC", /*ArgPos=*/0); +} nit: `/*MarcoFlag=*/`

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

yawanng updated this revision to Diff 110649. https://reviews.llvm.org/D35368 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecInotifyInit1Check.cpp clang-tidy/android/CloexecInotifyInit1Check.h docs/ReleaseNotes.rst

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. See the comment on https://reviews.llvm.org/D35372. https://reviews.llvm.org/D35368 ___ cfe-commits mailing list

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

yawanng updated this revision to Diff 106520. yawanng marked an inline comment as done. Herald added subscribers: xazax.hun, JDevlieghere. https://reviews.llvm.org/D35368 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-inotify-init1 + `_ check Please sort checks in alphabetical order.