glenjofe added a comment.
Thanks Eric. Can you commit on my behalf?
https://reviews.llvm.org/D35470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
glenjofe added inline comments.
Comment at: test/std/utilities/memory/pointer.conversion/to_address.pass.cpp:119
+ASSERT_NOEXCEPT(std::to_address(p4));
+assert(std::to_address(p4) == );
+}
EricWF wrote:
> Shouldn't one of these tests hit a non-noexcept
EricWF added inline comments.
Comment at: test/std/utilities/memory/pointer.conversion/to_address.pass.cpp:119
+ASSERT_NOEXCEPT(std::to_address(p4));
+assert(std::to_address(p4) == );
+}
Shouldn't one of these tests hit a non-noexcept function?
glenjofe updated this revision to Diff 123531.
glenjofe marked 2 inline comments as done.
glenjofe added a comment.
Address Eric's review comments.
https://reviews.llvm.org/D35470
Files:
include/memory
test/std/utilities/memory/pointer.conversion/to_address.pass.cpp
Index:
EricWF added a comment.
Initially this LGTM. I'll take another pass in the morning.
Comment at: include/memory:1096
template
-inline _LIBCPP_INLINE_VISIBILITY
+inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17
_Tp*
Just make this
glenjofe updated this revision to Diff 123520.
glenjofe added a comment.
Now implements P0653R2 which was accepted in Albuquerque.
https://reviews.llvm.org/D35470
Files:
include/memory
test/std/utilities/memory/pointer.conversion/to_address.pass.cpp
Index:
