This revision was automatically updated to reflect the committed changes.
Closed by commit rL308496: [Sema] Improve diagnostic message for unavailable
C++17 aligned (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D35520?vs=107140=107336#toc
Repository:
rL LLVM
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks.
https://reviews.llvm.org/D35520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ahatanak updated this revision to Diff 107140.
ahatanak marked 6 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D35520
Files:
include/clang/Basic/AlignedAllocation.h
include/clang/Basic/DiagnosticSemaKinds.td
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AlignedAllocation.h:12
+/// \brief Defines a function that returns the minimum OS versions supporting
+/// c++17's aligned allocation functions.
+///
c++17 -> C++17
arphaman added inline comments.
Comment at: include/clang/Basic/AlignedAllocation.h:25
+
+static inline VersionTuple alignedAllocMinVersion(llvm::Triple::OSType OS) {
+ switch (OS) {
Redundant `static`?
Comment at:
ahatanak created this revision.
This changes the error message Sema prints when an unavailable c++17 aligned
allocation function is selected.
Original message: "... possibly unavailable on x86_64-apple-macos10.12"
New message: "... only available on macosx 10.13 or newer"
This is a follow-up
