[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

2017-07-18 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. I pushed a new patch D35531 . This implements the logic in llvm AArch64SubTarget which seems to be the proper place to do this. Once that patch is reviewed/accepted, I will abandon this one. https://reviews.llvm.org/D35529

[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

2017-07-18 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang added a comment. In https://reviews.llvm.org/D35529#812427, @mstorsjo wrote: > Wouldn't it make more sense to set this by default within LLVM, where it's > already enabled by default for darwin? > > Currently there's this code there: > > AArch64Subtarget::AArch64Subtarget(const Triple

[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

2017-07-18 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Wouldn't it make more sense to set this by default within LLVM, where it's already enabled by default for darwin? Currently there's this code there: AArch64Subtarget::AArch64Subtarget(const Triple , const std::string , const

[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

2017-07-17 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. https://reviews.llvm.org/D35529 Files: docs/ClangCommandLineReference.rst lib/Basic/Targets.cpp test/Driver/coff-aarch64-fixed-x18.c Index: test/Driver/coff-aarch64-fixed-x18.c