This revision was automatically updated to reflect the committed changes.
Closed by commit rL320351: [mips] Removal of microMIPS64R6 (authored by
abeserminji).
Changed prior to commit:
https://reviews.llvm.org/D35624?vs=126331=126332#toc
Repository:
rL LLVM
https://reviews.llvm.org/D35624
sdardis added inline comments.
Comment at: lib/Basic/Targets/Mips.cpp:209
bool MipsTargetInfo::validateTarget(DiagnosticsEngine ) const {
+ // microMIPS64R6 backend is removed
+ if ((getTriple().getArch() == llvm::Triple::mips64 ||
"was removed."
abeserminji updated this revision to Diff 126331.
abeserminji added a comment.
Comment addressed.
https://reviews.llvm.org/D35624
Files:
include/clang/Basic/DiagnosticCommonKinds.td
lib/Basic/Targets/Mips.cpp
Index: lib/Basic/Targets/Mips.cpp
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
One nit inlined, you can address it when committing.
Comment at: Basic/Targets/Mips.cpp:206
bool MipsTargetInfo::validateTarget(DiagnosticsEngine ) const {
+ if
abeserminji updated this revision to Diff 108067.
abeserminji added a comment.
Comments resolved and patch adapted to current revision.
Repository:
rL LLVM
https://reviews.llvm.org/D35624
Files:
Basic/Targets/Mips.cpp
clang/Basic/DiagnosticCommonKinds.td
Index: Basic/Targets/Mips.cpp
abeserminji marked 2 inline comments as done.
abeserminji added a comment.
Comments resolved
Repository:
rL LLVM
https://reviews.llvm.org/D35624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sdardis added a reviewer: cfe-commits.
sdardis added a comment.
Also, this need to be posted to cfe-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D35624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
