This revision was automatically updated to reflect the committed changes.
Closed by commit rL323193: [Solaris] gcc toolchain handling revamp (authored by
fedor.sergeev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
This looks reasonable on the face of it.
I'm assuming you know the layout for Solaris, and it doesn't seem to change the
behavior of non-Solaris, so LGTM.
ro added a comment.
In https://reviews.llvm.org/D35755#931120, @krytarowski wrote:
> Do we still target Oracle Solaris or SmartOS? Just wondering and noted the
> domain change in e-mail.
Both, I'd say ;-) They still have much common heritage and the vast majority
of linker/toolchain work on
krytarowski added a comment.
In https://reviews.llvm.org/D35755#930789, @fedor.sergeev wrote:
> In https://reviews.llvm.org/D35755#930030, @ro wrote:
>
> > What's the status here? This patch is required for my WIP
> > sanitizers-on-Solaris work.
>
>
> since @tstellar just resolved the only
fedor.sergeev marked an inline comment as not done.
fedor.sergeev added a comment.
In https://reviews.llvm.org/D35755#930030, @ro wrote:
> What's the status here? This patch is required for my WIP
> sanitizers-on-Solaris work.
since @tstellar just resolved the only remaining question I will
tstellar added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:1840
+// Yet, still look for RHEL devtoolsets
+// (should it be done Linux-only??)
+Prefixes.push_back("/opt/rh/devtoolset-6/root/usr");
fedor.sergeev wrote:
> aaron.ballman
ro added a comment.
What's the status here? This patch is required for my WIP
sanitizers-on-Solaris work.
https://reviews.llvm.org/D35755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
fedor.sergeev marked an inline comment as not done.
fedor.sergeev added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.h:253
+void AddDefaultGCCPrefixes(const llvm::Triple ,
+ SmallVectorImpl ,
aaron.ballman wrote:
>
aaron.ballman added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.h:253
+void AddDefaultGCCPrefixes(const llvm::Triple ,
+ SmallVectorImpl ,
fedor.sergeev wrote:
> aaron.ballman wrote:
> > Might as well drop the
fedor.sergeev updated this revision to Diff 110194.
fedor.sergeev added a comment.
ugh... reverting back to llvm::Triple, since plain Triple conflicts with
clang::driver::Toolchain::Triple data member.
Built/tested on Solaris11 x86/SPARC, Linux x86.
https://reviews.llvm.org/D35755
Files:
fedor.sergeev updated this revision to Diff 110190.
fedor.sergeev added a comment.
auto changed to MultilibSet::IncludeDirsFunc.
https://reviews.llvm.org/D35755
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Gnu.h
lib/Driver/ToolChains/Solaris.cpp
aaron.ballman added a comment.
Aside from a coding style nit and the unanswered question that hopefully
@tstellar can help answer, this LGTM. I'll wait to accept until we figure out
the answer for Linux, however.
Comment at: lib/Driver/ToolChains/Solaris.cpp:208
if
fedor.sergeev added a reviewer: tstellar.
fedor.sergeev marked 11 inline comments as done.
fedor.sergeev added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:1840
+// Yet, still look for RHEL devtoolsets
+// (should it be done Linux-only??)
+
fedor.sergeev updated this revision to Diff 109593.
fedor.sergeev added a comment.
Corrected comments as suggested by Aaron.
Will be replying on other suggestions inline.
https://reviews.llvm.org/D35755
Files:
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Gnu.h
aaron.ballman added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:1511
+ StringRef Suff64 = "/64";
+ // Solaris uses platform-specific suffixes instead of /64
+ if (TargetTriple.getOS() == llvm::Triple::Solaris) {
Add a period at the end of the
fedor.sergeev added a comment.
ping?
https://reviews.llvm.org/D35755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fedor.sergeev created this revision.
General idea is to utilize generic (mostly Generic_GCC) code
and get rid of Solaris-specific handling as much as possible.
In particular:
- scanLibDirForGCCTripleSolaris was removed, relying on generic
CollectLibDirsAndTriples
- findBiarchMultilibs is now
17 matches
Mail list logo
