[PATCH] D35825: [clangd] Reuse compile commands during reparse

2017-07-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308970: [clangd] Reuse compile commands during reparse (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D35825 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp clang-tools-

[PATCH] D35825: [clangd] Reuse compile commands during reparse

2017-07-25 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D35825: [clangd] Reuse compile commands during reparse

2017-07-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 108033. krasimir added a comment. - Address review comment https://reviews.llvm.org/D35825 Files: clangd/ClangdUnit.cpp clangd/ClangdUnitStore.h Index: clangd/ClangdUnitStore.h === --- c

[PATCH] D35825: [clangd] Reuse compile commands during reparse

2017-07-25 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:248 + VFS->setCurrentWorkingDirectory(Command.Directory); + Also have to call it in `codeComplete`. https://reviews.llvm.org/D35825 ___ cfe-

[PATCH] D35825: [clangd] Reuse compile commands during reparse

2017-07-25 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Previously we always queried the compilation database and discarded the results if the file was already opened. https://reviews.llvm.org/D35825 Files: clangd/ClangdUnit.cpp clangd/ClangdUnitStore.h Index: clangd/ClangdUnitStore.h ===