This revision was automatically updated to reflect the committed changes.
Closed by commit rL309081: [clang] Add ARM64 support to armintr.h for MSVC
compatibility (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D35862?vs=108208=108222#toc
Repository:
rL LLVM
mgrang added a comment.
Patch updated as per comments.
https://reviews.llvm.org/D35862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgrang updated this revision to Diff 108208.
Herald added a subscriber: mgorny.
https://reviews.llvm.org/D35862
Files:
lib/Headers/CMakeLists.txt
lib/Headers/arm64intr.h
lib/Headers/intrin.h
Index: lib/Headers/intrin.h
===
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Please split this out into `arm64intr.h` and include it from `intrin.h` under a
`#if defined(_M_ARM64)` case before committing.
https://reviews.llvm.org/D35862
mstorsjo added a comment.
The Microsoft version of `intrin.h` includes a header named `arm64intr.h`
(IIRC), I think it'd be better for compatibility if we also provided a file
with the same name instead of reusing this one.
https://reviews.llvm.org/D35862
mgrang added a comment.
Refer
http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf
for memory barriers.
https://reviews.llvm.org/D35862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgrang created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
This fixes compiling with headers from the Windows SDK for ARM64.
https://reviews.llvm.org/D35862
Files:
lib/Headers/armintr.h
Index: lib/Headers/armintr.h
