[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

2017-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL310160: [OpenCL] Remove extra select functions from opencl-c.h (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D36259?vs=109486=109845#toc Repository: rL LLVM

[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

2017-08-03 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D36259#830122, @bader wrote: > Out of curiosity: how did you detect this? > Can we use the same approach for writing tests? Some user code generated call to a select function which we do not have in library, then Brian found that there are

[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

2017-08-03 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Out of curiosity: how did you detect this? Can we use the same approach for writing tests? https://reviews.llvm.org/D36259 ___ cfe-commits mailing

[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

2017-08-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. OpenCL spec v2.0 s6.13.6: gentype select (gentype a, gentype b, igentype c) gentype select (gentype a, gentype b, ugentype c) igentype and ugentype must have the same number of elements and bits as gentype. https://reviews.llvm.org/D36259 Files: