ilya-biryukov added a comment.
Thanks. I'll make sure to address the awkwardness in further commits.
https://reviews.llvm.org/D36397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310818: [clangd] Fixed a data race. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36397
Files:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clang
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I think this can be committed now. It's still a bit awkward but we can address
that later.
https://reviews.llvm.org/D36397
___
cfe-commits mai
ilya-biryukov added a comment.
A follow-up after discussion offline: we should make an attempt to simplify the
threading code in `ClangdUnit.h` by moving the async worker loop of `CppFile`
into the class itself, rather than relying on external scheduling to do the
right thing.
@klimek, are ther
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:714
-void CppFile::cancelRebuilds() {
+void CppFile::cancelRebuild() { deferCancelRebuild().get(); }
+
klimek wrote:
> Somewhat orthogonal question - why CppFile? We do support other languag
klimek added inline comments.
Comment at: clangd/ClangdUnit.cpp:714
-void CppFile::cancelRebuilds() {
+void CppFile::cancelRebuild() { deferCancelRebuild().get(); }
+
Somewhat orthogonal question - why CppFile? We do support other languages in
Clangd, right? (
ilya-biryukov added a comment.
In https://reviews.llvm.org/D36397#833912, @klimek wrote:
> Yea, we'll probably want to add a "smash it hard with parallel" requests kind
> of test to catch these things. You're right, there is probably not a better
> solution for this specific bug.
Added a rele
klimek added a comment.
In https://reviews.llvm.org/D36397#833890, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D36397#833883, @klimek wrote:
>
> > Tests?
>
>
> TSAN does not catch this (as it's a logical error) and it requires a rather
> bizarre timing of file reparses to trigger.
> I c
ilya-biryukov added a comment.
In https://reviews.llvm.org/D36397#833883, @klimek wrote:
> Tests?
TSAN does not catch this (as it's a logical error) and it requires a rather
bizarre timing of file reparses to trigger.
I couldn't come up with an example that would reproduce this.
https://revi
klimek added a comment.
Tests?
https://reviews.llvm.org/D36397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov created this revision.
Calling addDocument after removeDocument could have resulted in an
invalid program state (AST and Preamble for the valid document could
have been incorrectly removed).
This commit also includes an improved CppFile::cancelRebuild
implementation that allows to ca
11 matches
Mail list logo
