[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets
aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r310388 https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets
ormris added a comment. Great. Thanks for the review! I don't have commit access currently. https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets
probinson added a comment. FTR, from a PS4 perspective this is all good, but we'd like somebody from outside our team to take a look. https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets
ormris added a comment. An ABI change was introduced in r254596 that modified structure layouts when the 'packed' attribute was used on one-byte bitfields. Since the PS4 target needs to maintain backwards compatibility for all structure layouts, this change reintroduces the old behavior for PS4 targets only. It also introduces PS4 specific cases to the relevant test. See the following review for discussion of r254596. https://reviews.llvm.org/D14872 https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
