[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-10-04 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai abandoned this revision. smeenai added a comment. I ended up handling this differently internally (via a custom site config). If someone else ends up needing the same functionality, they can revive it. https://reviews.llvm.org/D36713 ___

[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-09-14 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. @mclow.lists, any final verdict here? I ended up doing this differently for my internal use case, so if you think this isn't generally useful, I'm happy to abandon. https://reviews.llvm.org/D36713 ___ cfe-commits mailing

[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-08-24 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Ping. https://reviews.llvm.org/D36713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-08-15 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. @mclow.lists does this seem reasonable to you? https://reviews.llvm.org/D36713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-08-14 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D36713#841478, @mclow.lists wrote: > What's the use case here? What are you trying to accomplish? The `_LIBCPP_DISABLE_AVAILABILITY` macro already exists, but since it influences headers, it's a lot more useful to have it as a site config

[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-08-14 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. What's the use case here? What are you trying to accomplish? https://reviews.llvm.org/D36713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-08-14 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-08-14 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Seems fine to me. Adding @dexonsmith (I don't know who maintain libc++ at Apple right now) https://reviews.llvm.org/D36713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36713: [libc++] Add a persistent way to disable availability

2017-08-14 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. Herald added a subscriber: mgorny. Add _LIBCPP_DISABLE_AVAILABILITY to the site config options, and add a cmake option LIBCXX_DISABLE_AVAILABILITY to control the site config. This is similar to other options which influence headers and therefore shold have some way