hans added a comment.
In https://reviews.llvm.org/D36872#847416, @nik wrote:
> I see this in trunk/master submitted, but not in the release_50 branch. Could
> this be cherry-picked to 5.0?
I've replied on the commit message thread. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D368
nik added a reviewer: hans.
nik added a comment.
I see this in trunk/master submitted, but not in the release_50 branch. Could
this be cherry-picked to 5.0?
Repository:
rL LLVM
https://reviews.llvm.org/D36872
___
cfe-commits mailing list
cfe-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311330: Fixed a crash on replaying Preamble's PP conditional
stack. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36872
Files:
cfe/trunk/include/clang/Lex/Preprocessor.h
c
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This looks good to me.
https://reviews.llvm.org/D36872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
In https://reviews.llvm.org/D36872#845364, @erikjv wrote:
> Can you check if the example in https://bugs.llvm.org/show_bug.cgi?id=33574
> works correctly?
Works correctly, added an extra test for it.
https://revie
ilya-biryukov updated this revision to Diff 111676.
ilya-biryukov added a comment.
- Removed redundant 'private' specifier.
- Added a test for https://bugs.llvm.org/show_bug.cgi?id=33574
https://reviews.llvm.org/D36872
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPLexerChange.cpp
lib/
erikjv added a comment.
Can you check if the example in https://bugs.llvm.org/show_bug.cgi?id=33574
works correctly?
Comment at: include/clang/Lex/Preprocessor.h:2029
+
private:
// Macro handling.
Duplicate "private:"
https://reviews.llvm.org/D36872
_
ilya-biryukov created this revision.
The crash occurs when the first token after a preamble is a macro
expansion.
Fixed by moving replayPreambleConditionalStack from Parser into
Preprocessor. It is now called right after the predefines file is
processed.
https://reviews.llvm.org/D36872
Files:
