mclow.lists added a comment.
This is an old patch; is this still needed/desired?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D37182/new/
https://reviews.llvm.org/D37182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
smeenai added a comment.
Sorry, this has been on my queue for a long time, but I haven't gotten the
chance to get to it yet. I'll try to take a look (at this and your other
patches) in the next few days.
https://reviews.llvm.org/D37182
___
cfe-com
hamzasood added a comment.
I have access now, so I'm able to commit this myself.
However it's been a while since it was approved, so I'd be grateful if someone
could take another look to make sure nothing has changed in the meantime
(besides potentially needing to re-tag some new APIs).
https:
hamzasood added a comment.
Thanks. Could someone commit this for me please?
Comment at: include/experimental/__config:57
+#if defined(_LIBCPP_OBJECT_FORMAT_COFF)
+# define _LIBCPPX_TYPE_VIS
compnerd wrote:
> hamzasood wrote:
> > smeenai wrote:
> > > I think i
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: include/experimental/__config:57
+#if defined(_LIBCPP_OBJECT_FORMAT_COFF)
+# define _LIBCPPX_TYPE_VIS
hamzasood wrote:
> smeenai wrote:
compnerd added a comment.
I think that splitting this up in a series of patches would be much better.
The first patch should be to do the entirely mechanical change of the
visibility attribute. It is a separate library and needs its own visibility
attribute. That would significantly slim dow
mclow.lists added a comment.
The reason for building the filesystem library as a statically linked lib
(instead of dynamic) is that for quite a while it was changing significantly.
Having people link statically means that we can make changes w/o worrying (as
much) about people using the librar
hamzasood added a comment.
In https://reviews.llvm.org/D37182#855262, @smeenai wrote:
> The other question, of course, is why the experimental library needs to be
> static. If it were built shared, the annotations would just work on Windows
> in theory (though I'm sure there are other issues th
smeenai added reviewers: mclow.lists, compnerd.
smeenai resigned from this revision.
smeenai added a comment.
It's really cool that you're getting the filesystem library to work on Windows
:)
This looks reasonable to me; it's the only way I can think of to get the
experimental library working o
