[PATCH] D37201: [clang-diff] Use correct SourceRange for CXXConstructExpr

[Johannes Altmanninger via Phabricator via cfe-commits]

johannes created this revision.
Herald added a subscriber: klimek.

This way the variable name of a declaration is not included


https://reviews.llvm.org/D37201

Files:
  test/Tooling/Inputs/clang-diff-basic-src.cpp
  test/Tooling/clang-diff-basic.cpp
  test/Tooling/clang-diff-html.test


Index: test/Tooling/clang-diff-html.test
===================================================================
--- test/Tooling/clang-diff-html.test
+++ test/Tooling/clang-diff-html.test
@@ -26,6 +26,20 @@
 update + move
 CHECK: 2' class='u m'>2</span>
 
+VarDecl of same type but different variable name
+ensure that only the latter is marked changed
+CHECK: VarDecl: s
+CHECK: TypeLoc: class T
+CHECK-NEXT: <span class='src'>T</span>{{.*}}CXXConstructExpr
+CHECK-NEXT: CXXConstructExpr
+CHECK: <span class='src u'> s</span>
+CHECK: CXXTemporaryObjectExpr
+CHECK-NEXT: CXXTemporaryObjectExpr
+CHECK-NEXT: <span class='src'></span>
+CHECK-NEXT: TypeLoc: class S
+CHECK-NEXT: <span class='src u'>S</span>
+
+
 insertion
 CHECK: <span id='R[[R:[0-9]+]]' tid='L-1' title='StringLiteral
 CHECK-NEXT: -1 -> [[R]]
Index: test/Tooling/clang-diff-basic.cpp
===================================================================
--- test/Tooling/clang-diff-basic.cpp
+++ test/Tooling/clang-diff-basic.cpp
@@ -97,5 +97,11 @@
 // CHECK-NEXT: Match DeclRefExpr: s3
 str x = s1 + s2 - s3;
 
+class S {}; class T {};
+void cons() {
+  T t;
+  (void) T();
+}
+
 // CHECK: Delete AccessSpecDecl: public
 // CHECK: Delete CXXMethodDecl
Index: test/Tooling/Inputs/clang-diff-basic-src.cpp
===================================================================
--- test/Tooling/Inputs/clang-diff-basic-src.cpp
+++ test/Tooling/Inputs/clang-diff-basic-src.cpp
@@ -61,3 +61,9 @@
 } s1, s2, s3;
 
 str x = s1 + s2 - s3;
+
+class S {}; class T {};
+void cons() {
+  T s;
+  (void) S();
+}



Index: test/Tooling/clang-diff-html.test
===================================================================
--- test/Tooling/clang-diff-html.test
+++ test/Tooling/clang-diff-html.test
@@ -26,6 +26,20 @@
 update + move
 CHECK: 2' class='u m'>2</span>
 
+VarDecl of same type but different variable name
+ensure that only the latter is marked changed
+CHECK: VarDecl: s
+CHECK: TypeLoc: class T
+CHECK-NEXT: <span class='src'>T</span>{{.*}}CXXConstructExpr
+CHECK-NEXT: CXXConstructExpr
+CHECK: <span class='src u'> s</span>
+CHECK: CXXTemporaryObjectExpr
+CHECK-NEXT: CXXTemporaryObjectExpr
+CHECK-NEXT: <span class='src'></span>
+CHECK-NEXT: TypeLoc: class S
+CHECK-NEXT: <span class='src u'>S</span>
+
+
 insertion
 CHECK: <span id='R[[R:[0-9]+]]' tid='L-1' title='StringLiteral
 CHECK-NEXT: -1 -> [[R]]
Index: test/Tooling/clang-diff-basic.cpp
===================================================================
--- test/Tooling/clang-diff-basic.cpp
+++ test/Tooling/clang-diff-basic.cpp
@@ -97,5 +97,11 @@
 // CHECK-NEXT: Match DeclRefExpr: s3
 str x = s1 + s2 - s3;
 
+class S {}; class T {};
+void cons() {
+  T t;
+  (void) T();
+}
+
 // CHECK: Delete AccessSpecDecl: public
 // CHECK: Delete CXXMethodDecl
Index: test/Tooling/Inputs/clang-diff-basic-src.cpp
===================================================================
--- test/Tooling/Inputs/clang-diff-basic-src.cpp
+++ test/Tooling/Inputs/clang-diff-basic-src.cpp
@@ -61,3 +61,9 @@
 } s1, s2, s3;
 
 str x = s1 + s2 - s3;
+
+class S {}; class T {};
+void cons() {
+  T s;
+  (void) S();
+}

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits