This revision was automatically updated to reflect the committed changes.
Closed by commit rL312546: [diagtool] Change default tree behavior to print
only flags (authored by JDevlieghere).
Changed prior to commit:
https://reviews.llvm.org/D37390?vs=113737=113885#toc
Repository:
rL LLVM
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
Please precommit the `auto` loop modernization though. You might want to use
`llvm::make_range` for for-ranged loops as well.
https://reviews.llvm.org/D37390
JDevlieghere updated this revision to Diff 113737.
JDevlieghere added a comment.
Thanks Alex!
https://reviews.llvm.org/D37390
Files:
test/Misc/warning-flags-tree.c
tools/diagtool/TreeView.cpp
Index: tools/diagtool/TreeView.cpp
arphaman added a comment.
The diagtool tests should go to `test/Misc`, and there's an existing `diagtool
tree` test there that has to be updated as well.
Repository:
rL LLVM
https://reviews.llvm.org/D37390
___
cfe-commits mailing list
JDevlieghere updated this revision to Diff 113731.
JDevlieghere added a comment.
Herald added subscribers: aheejin, klimek.
Thanks for the review Adrian!
I somehow completely overlooked the existing `--flags-only` option in `diagtool
tree`. Obviously it makes much more sense to implement
