alexfh added a comment.
In https://reviews.llvm.org/D37566#866096, @PriMee wrote:
> Done :) Could you please commit this for me?
Sure, just committed the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D37566
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313150: [clang-tidy] fixed misc-unused-parameters omitting
parameters default value (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D37566?vs=114538=115047#toc
Repository:
rL
PriMee updated this revision to Diff 114538.
PriMee added a comment.
Done :) Could you please commit this for me?
https://reviews.llvm.org/D37566
Files:
clang-tidy/misc/UnusedParametersCheck.cpp
test/clang-tidy/misc-unused-parameters.cpp
Index: test/clang-tidy/misc-unused-parameters.cpp
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thank you for the fix!
LG with one nit.
Comment at: test/clang-tidy/misc-unused-parameters.cpp:73
+// CHECK-FIXES: staticFunctionE();
+ staticFunctionF(1);
+//
PriMee created this revision.
Herald added a subscriber: JDevlieghere.
Bug: https://bugs.llvm.org/show_bug.cgi?id=34450
**Problem:**
Clang-tidy check misc-unused-parameters omits parameter default value what
results in its complete removal. Compilation errors might occur after
clang-tidy fix.
