Re: [PATCH] D37604: Disable debuginfo-tests for non-native configurations

[Adrian Prantl via cfe-commits]

> On Sep 8, 2017, at 11:43 AM, Adrian Prantl  wrote:
> 
> 
>> On Sep 8, 2017, at 10:54 AM, Paul Robinson via Phabricator 
>>  wrote:
>> 
>> probinson added a comment.
>> 
>> In https://reviews.llvm.org/D37604#864187, @aprantl wrote:
>> 
>>> This seems reasonable to me, thanks!
>>> When you commit this, could you please double-check that the tests are 
>>> still running on the green dragon builders? I'll also keep an eye on them.
> 
>> 
>> I was able to google "llvm green dragon" and find what looks like the right 
>> page, but I kind of would have expected to see a link on the llvm.org front 
>> page?  Am I just not looking in the right place?
> 
> This is our canonical url: http://green.lab.llvm.org/green/
> I've CC'ed Mike, perhaps he can work with Tanya to feature the link more 
> prominently?
> 
> I just checked and the tests are running in the first green build after your 
> commit:
> http://green.lab.llvm.org/green/job/clang-stage1-configure-RA_check/35303/consoleFull
> 

Sorry — there was an infrastructure issue this morning, that caused those 
builds to not finish chronologically, The run of the tests after your commit 
hasn't started yet. I'll watch out for it.

-- adrian

> PASS: Clang :: debuginfo-tests/aggregate-indirect-arg.cpp (11846 of 39540)
> PASS: Clang :: debuginfo-tests/vla.c (11847 of 39540)
> PASS: Clang :: debuginfo-tests/dbg-arg.c (11848 of 39540)
> PASS: Clang :: debuginfo-tests/sret.cpp (11849 of 39540)
> PASS: Clang :: debuginfo-tests/ctor.cpp (11850 of 39540)
> PASS: Clang :: debuginfo-tests/stack-var.c (11851 of 39540)
> 
> ...
> 
> thanks for checking!
> adrian

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D37604: Disable debuginfo-tests for non-native configurations

[Adrian Prantl via cfe-commits]

> On Sep 8, 2017, at 10:54 AM, Paul Robinson via Phabricator 
>  wrote:
> 
> probinson added a comment.
> 
> In https://reviews.llvm.org/D37604#864187, @aprantl wrote:
> 
>> This seems reasonable to me, thanks!
>> When you commit this, could you please double-check that the tests are still 
>> running on the green dragon builders? I'll also keep an eye on them.

> 
> I was able to google "llvm green dragon" and find what looks like the right 
> page, but I kind of would have expected to see a link on the llvm.org front 
> page?  Am I just not looking in the right place?

This is our canonical url: http://green.lab.llvm.org/green/
I've CC'ed Mike, perhaps he can work with Tanya to feature the link more 
prominently?

I just checked and the tests are running in the first green build after your 
commit:
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA_check/35303/consoleFull

PASS: Clang :: debuginfo-tests/aggregate-indirect-arg.cpp (11846 of 39540)
PASS: Clang :: debuginfo-tests/vla.c (11847 of 39540)
PASS: Clang :: debuginfo-tests/dbg-arg.c (11848 of 39540)
PASS: Clang :: debuginfo-tests/sret.cpp (11849 of 39540)
PASS: Clang :: debuginfo-tests/ctor.cpp (11850 of 39540)
PASS: Clang :: debuginfo-tests/stack-var.c (11851 of 39540)

...

thanks for checking!
adrian
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

[Paul Robinson via Phabricator via cfe-commits]

probinson added a comment.

In https://reviews.llvm.org/D37604#864187, @aprantl wrote:

> This seems reasonable to me, thanks!
>  When you commit this, could you please double-check that the tests are still 
> running on the green dragon builders? I'll also keep an eye on them.


I was able to google "llvm green dragon" and find what looks like the right 
page, but I kind of would have expected to see a link on the llvm.org front 
page?  Am I just not looking in the right place?


https://reviews.llvm.org/D37604



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

[Paul Robinson via Phabricator via cfe-commits]

probinson closed this revision.
probinson added a comment.

r312803.  Forgot to put the tag in the commit message


https://reviews.llvm.org/D37604



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

[Adrian Prantl via Phabricator via cfe-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

This seems reasonable to me, thanks!
When you commit this, could you please double-check that the tests are still 
running on the green dragon builders? I'll also keep an eye on them.


https://reviews.llvm.org/D37604



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

[Paul Robinson via Phabricator via cfe-commits]

probinson added a comment.

The new file goes in the debuginfo-tests directory.  It's a separate project so 
that's probably not obvious from the diff.


https://reviews.llvm.org/D37604



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

[Paul Robinson via Phabricator via cfe-commits]

probinson created this revision.

This requires the host triple to match the default target triple, in order to 
run debuginfo-tests.
It's possible this is too restrictive, but offhand it seems like a reasonable 
starting point.


https://reviews.llvm.org/D37604

Files:
  lit.local.cfg


Index: lit.local.cfg
===
--- lit.local.cfg
+++ lit.local.cfg
@@ -0,0 +1,3 @@
+# debuginfo-tests are not expected to pass in a cross-compilation setup.
+if 'native' not in config.available_features:
+config.unsupported = True


Index: lit.local.cfg
===
--- lit.local.cfg
+++ lit.local.cfg
@@ -0,0 +1,3 @@
+# debuginfo-tests are not expected to pass in a cross-compilation setup.
+if 'native' not in config.available_features:
+config.unsupported = True
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits