This revision was automatically updated to reflect the committed changes.
Closed by commit rL312792: [Sema] Put tautological comparison of unsigned and
zero into it's own flag (authored by lebedevri).
Changed prior to commit:
https://reviews.llvm.org/D37620?vs=114351=114358#toc
Repository:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Please run the test through clang-format, but otherwise LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D37620
___
lebedev.ri updated this revision to Diff 114351.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.
Added test.
Repository:
rL LLVM
https://reviews.llvm.org/D37620
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
The bulk of the patch LGTM as well, but it should still have a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D37620
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Right, of course.
Thanks and LG, but clearly also get a review from someone more familiar with
the code (I'm just a buildcop)
Repository:
rL LLVM
https://reviews.llvm.org/D37620
aaron.ballman added a comment.
In https://reviews.llvm.org/D37620#864684, @sammccall wrote:
> Thanks!
> Unless I'm missing something, the current patch just adds the category, but
> doesn't actually recategorize the warning, right?
The diagnostics in DiagnosticSemaKinds.td are changed to be
sammccall added a comment.
Thanks!
Unless I'm missing something, the current patch just adds the category, but
doesn't actually recategorize the warning, right?
Repository:
rL LLVM
https://reviews.llvm.org/D37620
___
cfe-commits mailing list
aaron.ballman added a comment.
> Does this need test?
Yes, it does -- I'd add one with two RUN lines, one with the flag and one
without it to make sure you only get the diagnostics in one case.
Repository:
rL LLVM
https://reviews.llvm.org/D37620
lebedev.ri created this revision.
lebedev.ri added a project: clang.
As requested by Sam McCall.
$ /build/llvm-build-Clang-release/./bin/clang -c
/build/clang/test/Sema/outof-range-constant-compare.c
/build/clang/test/Sema/outof-range-constant-compare.c:40:11: warning:
comparison of
