This revision was automatically updated to reflect the committed changes.
Closed by commit rL313133: [X86] [PATCH] [intrinsics] Lowering X86 ABS
intrinsics to IR. (clang) (authored by uriel.k).
Changed prior to commit:
https://reviews.llvm.org/D37694?vs=114613=115001#toc
Repository:
rL LLVM
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
Oops you are correct. Sorry.
LGTM
https://reviews.llvm.org/D37694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
uriel.k added a comment.
If I remove the builtins from the .def file this will not work, as I didn't
replace the builtin call in the Header files but implemented the lowering by
adding cases to the CGBuiltin.cpp and adding the IR by hand.
https://reviews.llvm.org/D37694
craig.topper added a comment.
Remove the builtins from BuiltinsX86.def
https://reviews.llvm.org/D37694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
uriel.k created this revision.
This patch, together with a matching llvm patch
(https://reviews.llvm.org/D37693), implements the lowering of X86 ABS
intrinsics to IR.
https://reviews.llvm.org/D37694
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx2-builtins.c
