This revision was automatically updated to reflect the committed changes.
Closed by commit rC323897: [WebAssembly] Dont pass
-ffunction-section/-fdata-sections (authored by sbc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D37831?vs=132098=132213#toc
Repository:
rC
dschuff added a comment.
In https://reviews.llvm.org/D37831#992822, @sbc100 wrote:
> After a little discussion about this and the -gc-sections linker flag, the
> augments for the tools having sensible defaults seem to be winning.
Well sure, when you put it that way, nobody can argue against
sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D37831#871238, @dschuff wrote:
> I think the reasoning was really just that code size reduction is even more
> important on wasm than other platforms, and
sbc100 added a comment.
After a little discussion about this and the -gc-sections linker flag, the
augments for the tools having sensible defaults seem to be winning.
This means we don't need the driver to pass these options, which makes our
commands lines shorter, and it also means that
sbc100 updated this revision to Diff 132098.
sbc100 added a comment.
Herald added subscribers: cfe-commits, sunfish.
- update tests
Repository:
rC Clang
https://reviews.llvm.org/D37831
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/wasm-toolchain.c
