[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

gtbercea updated this revision to Diff 115941. gtbercea added a comment. Address comment. Repository: rL LLVM https://reviews.llvm.org/D37912 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

tra added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:441 -SmallString<256> Name = llvm::sys::path::filename(II.getFilename()); +SmallString<256> Name = StringRef(II.getFilename()); llvm::sys::path::replace_extension(Name, "cubin");

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

gtbercea updated this revision to Diff 115667. gtbercea added a reviewer: hfinkel. Repository: rL LLVM https://reviews.llvm.org/D37912 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

hfinkel added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:442 +SmallString<256> Name = llvm::sys::path::relative_path(II.getFilename()); +SmallString<256> FullPath = llvm::sys::path::root_path(II.getFilename());

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

gtbercea updated this revision to Diff 115497. gtbercea added a comment. Fix tests. https://reviews.llvm.org/D37912 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

tra added a comment. In https://reviews.llvm.org/D37912#872318, @gtbercea wrote: > In https://reviews.llvm.org/D37912#872294, @tra wrote: > > > Shouldn't this temp .cubin file go into the temporary directory, as opposed > > to the same directory as the input file? > > > That is indeed the

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

gtbercea added a comment. In https://reviews.llvm.org/D37912#872294, @tra wrote: > Shouldn't this temp .cubin file go into the temporary directory, as opposed > to the same directory as the input file? That is indeed the intention. The filename already contains the "/tmp/" I just make sure

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

tra added a comment. Shouldn't this temp .cubin file go into the temporary directory, as opposed to the same directory as the input file? Repository: rL LLVM https://reviews.llvm.org/D37912 ___ cfe-commits mailing list

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

gtbercea created this revision. When composing the output file name, the path to the file is being dropped. The full path is required. Repository: rL LLVM https://reviews.llvm.org/D37912 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp