This revision was automatically updated to reflect the committed changes.
Closed by commit rL313992: [Atomic][X8664] set max atomic inline width
according to the target (authored by wmi).
Changed prior to commit:
https://reviews.llvm.org/D38046?vs=116107=116362#toc
Repository:
rL LLVM
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D38046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
wmi updated this revision to Diff 116107.
wmi added a comment.
Herald added a subscriber: eraman.
Address Eli's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D38046
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/Basic/Targets/X86.h
wmi added inline comments.
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+}
efriedma wrote:
> wmi wrote:
> > efriedma wrote:
> > > I don't think we need to mess with MaxAtomicPromoteWidth?
> > >
efriedma added inline comments.
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+}
wmi wrote:
> efriedma wrote:
> > I don't think we need to mess with MaxAtomicPromoteWidth?
> >
> > Probably more
wmi added inline comments.
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+}
efriedma wrote:
> I don't think we need to mess with MaxAtomicPromoteWidth?
>
> Probably more intuitive to check "if
efriedma added a comment.
Needs testcase.
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+}
I don't think we need to mess with MaxAtomicPromoteWidth?
Probably more intuitive to check "if
wmi updated this revision to Diff 115945.
wmi added a comment.
Address Eli's comment.
Repository:
rL LLVM
https://reviews.llvm.org/D38046
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/Basic/Targets/X86.h
test/OpenMP/atomic_capture_codegen.cpp
