This revision was automatically updated to reflect the committed changes.
Closed by commit rL315865: MACHO: ld64.lld alias for the MACHO LLD target
(authored by martell).
Changed prior to commit:
https://reviews.llvm.org/D38290?vs=116801=119087#toc
Repository:
rL LLVM
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D38290#885503, @ruiu wrote:
> This patch virtually sets `ld64` the linker command name for macOS. I'd be a
> bit reluctant doing that, because `ld64` sounds like a too
martell added a comment.
`CODE_OWNERS.TXT` does not have a list of `driver` owners.
It does have rsmith as an owner for all things not covered by someone else so I
added him.
Reid usually reviews driver patches I submit to clang and is on the owner list
so I added him here initially.
I think
ruiu added a comment.
This patch virtually sets `ld64` the linker command name for macOS. I'd be a
bit reluctant doing that, because `ld64` sounds like a too generic name to
indicate "a linker for macOS". But that's probably okay because we don't have a
better name.
Can you get an LGTM from
martell added a comment.
In https://reviews.llvm.org/D38290#882911, @ruiu wrote:
> Is this for cross-compilation?
It is mostly for native compilation on mac but this will work for cross
compiling also.
> If you invoke lld on macOS, it should act as ld64.
That is if the file name is `ld` or
ruiu added a comment.
Is this for cross-compilation? If you invoke lld on macOS, it should act as
ld64.
macOS lld is not actively maintained, so I wouldn't make it available more
widely.
Repository:
rL LLVM
https://reviews.llvm.org/D38290
___
martell updated this revision to Diff 116801.
martell added a comment.
address comment
Repository:
rL LLVM
https://reviews.llvm.org/D38290
Files:
tools/clang/lib/Driver/ToolChain.cpp
tools/lld/tools/lld/CMakeLists.txt
tools/lld/tools/lld/lld.cpp
Index: tools/lld/tools/lld/lld.cpp
mstorsjo added inline comments.
Comment at: tools/clang/lib/Driver/ToolChain.cpp:394
+llvm::SmallString<8> LinkerName;
+if(Triple.isOSDarwin())
+ LinkerName.append("ld64.");
Space between `if` and `(`
Repository:
rL LLVM
martell added a comment.
I have a patch that does a bunch of updates for testing lld correctly in clang
and this was a part of it but I didn't want the patch to get too involved so I
separated this out.
I have seen this issue raised on various forums such as stackoverflow here and
figured I
martell created this revision.
Herald added a subscriber: mgorny.
Currently when we do `-fuse-ld=lld` for apple targets this invokes the gnu
frontend because of the `ld.lld` alias
This creates a new alias for ld64 as `ld64.lld` to avoid this.
Repository:
rL LLVM
10 matches
Mail list logo
