ilya-biryukov added a comment.
In https://reviews.llvm.org/D38627#892773, @chapuni wrote:
> Excuse me, Ubuntu 14.04's g++-4.8.4 doesn't compile it. :(
> Any idea?
Sorry about that. Fixed in https://reviews.llvm.org/rL315284.
clang and gcc (at least version 4.8) behave differently here, so I
chapuni added a comment.
Excuse me, Ubuntu 14.04's g++-4.8.4 doesn't compile it. :(
Any idea?
In file included from clang-tools-extra/clangd/ClangdServer.h:23:0,
from clang-tools-extra/clangd/ClangdServer.cpp:10:
clang-tools-extra/clangd/Function.h: In instantiation of
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Function.h:9
+//===--===//
+
+#ifndef
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315210: [clangd] Added move-only function helpers. (authored
by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D38627
Files:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
ilya-biryukov updated this revision to Diff 118184.
ilya-biryukov added a comment.
- Use proper types (Args&&) when forwarding arguments.
https://reviews.llvm.org/D38627
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/Function.h
Index: clangd/Function.h
ilya-biryukov updated this revision to Diff 118204.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
Addressed review comments.
- Added a file comment.
- Simplified callsites of UniqueFunction in ClangdServer.h
- Properly forward UniqueFunction's constructor
ilya-biryukov added inline comments.
Comment at: clangd/Function.h:36
+ template
+ UniqueFunction(Callable Func)
+ : CallablePtr(llvm::make_unique<
sammccall wrote:
> Do you want this constructor to be explicit?
>
> If not, I think you should be able to
