[PATCH] D39331: Add flags to control the -finstrument-functions instrumentation calls to __cyg_profile functions

2017-11-13 Thread Hans Wennborg via Phabricator via cfe-commits
hans added inline comments. Comment at: include/clang/Driver/Options.td:1032 +def fno_instrument_functions_inline : Flag<["-"], "fno-instrument-functions-inline">, Group, Flags<[CC1Option]>, + HelpText<"When using -finstrument-functions, insert the calls after inlining">;

[PATCH] D39331: Add flags to control the -finstrument-functions instrumentation calls to __cyg_profile functions

2017-11-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: include/clang/Driver/Options.td:1032 +def fno_instrument_functions_inline : Flag<["-"], "fno-instrument-functions-inline">, Group, Flags<[CC1Option]>, + HelpText<"When using -finstrument-functions, insert the calls after inlining">;

[PATCH] D39331: Add flags to control the -finstrument-functions instrumentation calls to __cyg_profile functions

2017-11-10 Thread Hans Wennborg via Phabricator via cfe-commits
hans updated this revision to Diff 122557. hans added a comment. Updating to match the LLVM-side: https://reviews.llvm.org/D39287#inline-348143 https://reviews.llvm.org/D39331 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp

[PATCH] D39331: Add flags to control the -finstrument-functions instrumentation calls to __cyg_profile functions

2017-10-27 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. The request for -fno-cygprofile-args was from another user. You raise a good point, it sounds like mcount() might be perfect for them :-) https://reviews.llvm.org/D39331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39331: Add flags to control the -finstrument-functions instrumentation calls to __cyg_profile functions

2017-10-26 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. Quick question: We're talking about a few different variants on this feature now: Post-inlining instrumentation, only marking function entries, and not passing the function address. Do you intend to use all of these things separately? I ask because, taken together,

[PATCH] D39331: Add flags to control the -finstrument-functions instrumentation calls to __cyg_profile functions

2017-10-26 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. This adds two flags: -fno-cygprofile-exit Don't insert any calls for function exit. -fno-cygprofile-args Don't pass any arguments to the cygprofile functions (the implementer has to figure out the caller address themselves) These are useful for reducing the size and