[PATCH] D39372: Make DiagnosticIDs::getAllDiagnostics static.

2017-11-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318150: Make DiagnosticIDs::getAllDiagnostics static. NFC. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D39372?vs=121104=122822#toc Repository: rL LLVM

[PATCH] D39372: Make DiagnosticIDs::getAllDiagnostics static.

2017-11-13 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D39372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39372: Make DiagnosticIDs::getAllDiagnostics static.

2017-10-30 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. I like the idea of making functions that can be static, static. Could you update the usages of this function as well? https://reviews.llvm.org/D39372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39372: Make DiagnosticIDs::getAllDiagnostics static.

2017-10-27 Thread András Leitereg via Phabricator via cfe-commits
leanil created this revision. It doesn't depend on instance specific data, so this would make it easier to use, for example here : https://reviews.llvm.org/D39372 Files: include/clang/Basic/DiagnosticIDs.h lib/Basic/DiagnosticIDs.cpp Index: