[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete closed this revision. Rakete added a comment. Committed in r336922 :) https://reviews.llvm.org/D39679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 154875. Rakete added a comment. Rebased + friendly ping :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 152441. Rakete added a comment. done :) Could you commit it please, @rsmith ? https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In any case, this looks good to me. It'll look even better with the `FK_AddressOfUnaddressableFunction` case fixed :) https://reviews.llvm.org/D39679

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

rsmith added a comment. In https://reviews.llvm.org/D39679#1037591, @Rakete wrote: > Note: I didn't change `Args[0]` to `OnlyArg` in > `FK_AddressOfUnaddressableFunction`, because I'm pretty sure that C++ doesn't > have unaddressable functions and thus there is no need to decompose an >

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 152370. Rakete added a comment. Rebased + friendly ping :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 148564. Rakete added a comment. Rebased + friendly ping :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 138423. Rakete added a comment. Addressed review comments :) I added a test case for the crashing code. Note: I didn't change `Args[0]` to `OnlyArg` in `FK_AddressOfUnaddressableFunction`, because I'm pretty sure that C++ doesn't have unaddressable

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

rsmith added inline comments. Comment at: lib/Sema/SemaInit.cpp:7691-7695 case FK_RValueReferenceBindingToLValue: S.Diag(Kind.getLocation(), diag::err_lvalue_to_rvalue_ref) << DestType.getNonReferenceType() << Args[0]->getType() <<

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 128661. Rakete added a comment. Rebased + friendly 2018 ping :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 121712. https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp === --- test/SemaCXX/references.cpp +++

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete created this revision. Rakete added a project: clang. This fixes PR34912 :) https://reviews.llvm.org/D39679 Files: lib/Sema/SemaInit.cpp test/SemaCXX/references.cpp Index: test/SemaCXX/references.cpp