This revision was automatically updated to reflect the committed changes.
Closed by commit rL319552: [clangd] Filter completion results by fuzzy-matching
identifiers. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D39882?vs=125009=125155#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE319552: [clangd] Filter completion results by
fuzzy-matching identifiers. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D39882?vs=125009=125154#toc
Repository:
rL LLVM
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall added a comment.
@ilya-biryukov Ping... this is the patch we wanted to land this week, so long
result sets are correct for user testing next week.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39882
___
cfe-commits
sammccall updated this revision to Diff 125009.
sammccall added a comment.
Herald added a subscriber: klimek.
Rebase and remove debug output.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39882
Files:
clangd/ClangdUnit.cpp
unittests/clangd/ClangdTests.cpp
Index:
sammccall added a comment.
In https://reviews.llvm.org/D39882#932858, @ilya-biryukov wrote:
> We definitely need to:
>
> - Rebase this change on top of current head (to account for limits and
> scoring)
Done. There's very little interaction - for now the match doesn't affect
scoring, we're
sammccall updated this revision to Diff 124043.
sammccall added a comment.
Rebase
https://reviews.llvm.org/D39882
Files:
clangd/ClangdUnit.cpp
unittests/clangd/ClangdTests.cpp
Index: unittests/clangd/ClangdTests.cpp
===
---
ilya-biryukov added a comment.
We definitely need to:
- Rebase this change on top of current head (to account for limits and scoring)
- Set `incomplete=true` for fuzzy-matched completion results
Maybe also make fuzzy-matching configurable via a flag? Off-by-default for now,
so we could start
sammccall created this revision.
This allows us to limit the number of results we return and still allow them
to be surfaced by refining a query (https://reviews.llvm.org/D39852).
The initial algorithm is very conservative - it accepts a completion if the
filter is any case-insensitive
