[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

2017-11-21 Thread Ivan Kosarev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318752: [CodeGen] Generate TBAA type descriptors in a more reliable manner (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D39953?vs=123563=123754#toc Repository: rL LLVM

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

2017-11-20 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, looks good. https://reviews.llvm.org/D39953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

2017-11-20 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev added a comment. In https://reviews.llvm.org/D39953#929144, @rjmccall wrote: > I think there might be some cases that intentionally don't cache their normal > result, though, so it might be harder than you think. My understanding is that conceptually every canonical type has a single

[PATCH] D39953: [CodeGen] Generate TBAA type descriptors in a more reliable manner

2017-11-20 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev updated this revision to Diff 123563. kosarev retitled this revision from "[CodeGen] Do not lookup for cached TBAA metadata nodes twice" to "[CodeGen] Generate TBAA type descriptors in a more reliable manner". kosarev edited the summary of this revision. kosarev added a comment.