[PATCH] D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll

2017-12-04 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin marked an inline comment as done. halyavin added inline comments. Comment at: src/support/runtime/exception_pointer_msvc.ipp:119-123 +#ifdef _M_AMD64 +RtlPcToFileHeader( +reinterpret_cast(const_cast(throw_info)), +_base); +#endif

[PATCH] D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll

2017-12-04 Thread David Majnemer via Phabricator via cfe-commits
majnemer added inline comments. Comment at: src/support/runtime/exception_pointer_msvc.ipp:119-123 +#ifdef _M_AMD64 +RtlPcToFileHeader( +reinterpret_cast(const_cast(throw_info)), +_base); +#endif Can't you use the image_base

[PATCH] D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll

2017-12-04 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin updated this revision to Diff 125356. halyavin added a comment. Updated diff to include whole context. https://reviews.llvm.org/D40071 Files: include/exception src/support/runtime/exception_pointer_msvc.ipp Index: src/support/runtime/exception_pointer_msvc.ipp

[PATCH] D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll

2017-11-15 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin created this revision. Herald added a reviewer: EricWF. This change removes dependency on Microsoft STL implementation but adds dependency on VC runtime implementation. We will need to evolve and add #ifdef's to this code as new versions of Visual Studio runtime will come out. Tested