This revision was automatically updated to reflect the committed changes.
Closed by commit rL318995: Control-Flow Enforcement Technology - Shadow Stack
and Indirect Branch Tracking… (authored by orenb).
Changed prior to commit:
https://reviews.llvm.org/D40224?vs=123937=124287#toc
Repository:
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D40224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
oren_ben_simhon updated this revision to Diff 123937.
oren_ben_simhon added a comment.
Implemented comments posted until 11/21 (Thanks Craig)
Repository:
rL LLVM
https://reviews.llvm.org/D40224
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/BuiltinsX86_64.def
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsX86_64.def:63
TARGET_BUILTIN(__builtin_ia32_xsaves64, "vv*ULLi", "", "xsaves")
+TARGET_BUILTIN(__builtin_ia32_incsspq, "vULLi","u","shstk")
+TARGET_BUILTIN(__builtin_ia32_rdsspq,
oren_ben_simhon updated this revision to Diff 123835.
oren_ben_simhon marked an inline comment as done.
oren_ben_simhon added a comment.
Implemented comments posted until 11/20 (Thanks Craig and Erich).
Repository:
rL LLVM
https://reviews.llvm.org/D40224
Files:
oren_ben_simhon marked 8 inline comments as done.
oren_ben_simhon added inline comments.
Comment at: include/clang/Driver/Options.td:1801
def mno_stackrealign : Flag<["-"], "mno-stackrealign">, Group;
+def mno_cet : Flag<["-"], "mno-cet">, Group;
+def mno_shstk : Flag<["-"],
craig.topper added inline comments.
Comment at: include/clang/Basic/BuiltinsX86.def:642
+// SHSTK
+TARGET_BUILTIN(__builtin_ia32_incsspd, "vUi","u","shstk")
+TARGET_BUILTIN(__builtin_ia32_rdsspd, "UiUi","Un","shstk")
Space after commas to match the rest of the
