This revision was automatically updated to reflect the committed changes.
Closed by commit rL320419: [Driver][CodeGen] Add -mprefer-vector-width driver
option and attribute during… (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D40230?vs=123709=126434#toc
Repository:
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D40230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
craig.topper updated this revision to Diff 123709.
craig.topper added a comment.
Still pass the attribute the backend if the value is 'none'.
We actually need this to know if the user specified the command line option at
all. The value of 'none' should disable limits and prevents needing to
craig.topper updated this revision to Diff 123614.
craig.topper added a comment.
Address comments.
The value of 'none' is intended to cancel out any other option specified. I've
changed it so that we no longer pass 'none' to llvm and instead suppress the
attribute.
spatel added a reviewer: hfinkel.
spatel added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.h:254
+ /// The prefered vector width.
+ std::string PreferVectorWidth;
typo - 'preferred'. Should add a bit more to the explanation. "The
craig.topper created this revision.
This adds a new command line option -mprefer-vector-width to specify a
preferred vector width for the vectorizers. Valid values are 'none' and
unsigned integers. The driver will check that it meets those constraints.
Specific supported integers will be
