aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r318794, thank you!
https://reviews.llvm.org/D40261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett added a comment.
It'd be great if you could commit it -- I don't have commit privileges. Much
appreciated!
https://reviews.llvm.org/D40261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
juliehockett updated this revision to Diff 123701.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D40261
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
juliehockett updated this revision to Diff 123654.
juliehockett added a comment.
Removed spurious semicolons
https://reviews.llvm.org/D40261
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a minor nit with the comments leading to the public docs, LGTM!
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5825-5826
+/// \code
+/// void
juliehockett updated this revision to Diff 123646.
juliehockett added a comment.
Updated Registry.cpp to include new matcher.
https://reviews.llvm.org/D40261
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
aaron.ballman added a comment.
You should also update lib\ASTMatchers\Dynamic\Registry.cpp to have the new
matcher (be sure to keep the new matcher alphabetized as well).
https://reviews.llvm.org/D40261
___
cfe-commits mailing list
juliehockett created this revision.
Herald added a subscriber: klimek.
Adds AST matcher for declarations with default arguments.
https://reviews.llvm.org/D40261
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h