[PATCH] D40270: [Modules TS] Added re-export support

2017-11-22 Thread Boris Kolpackov via Phabricator via cfe-commits
boris added a comment. All our tests pass as well. Thanks for your work! Repository: rL LLVM https://reviews.llvm.org/D40270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40270: [Modules TS] Added re-export support

2017-11-21 Thread Hamza Sood via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318744: [Modules TS] Added module re-export support. (authored by hamzasood). Changed prior to commit: https://reviews.llvm.org/D40270?vs=123666=123736#toc Repository: rL LLVM

[PATCH] D40270: [Modules TS] Added re-export support

2017-11-20 Thread Boris Kolpackov via Phabricator via cfe-commits
boris added a comment. LGTM. Will be happy to also run our re-export tests in build2 once this is merged. https://reviews.llvm.org/D40270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40270: [Modules TS] Added re-export support

2017-11-20 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks great. Comment at: test/CXX/modules-ts/dcl.dcl/dcl.module/dcl.module.export/p1.cpp:22 +} +#endif + Maybe consider adding one more module to

[PATCH] D40270: [Modules TS] Added re-export support

2017-11-20 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood created this revision. This patch adds support for re-exporting modules as described in `[dcl.modules.export]` https://reviews.llvm.org/D40270 Files: include/clang/Parse/Parser.h lib/Parse/ParseObjc.cpp lib/Parse/Parser.cpp lib/Sema/SemaDecl.cpp