This revision was automatically updated to reflect the committed changes.
Closed by commit rL318785: Add -finstrument-function-entry-bare flag (authored
by hans).
Changed prior to commit:
https://reviews.llvm.org/D40276?vs=123691=123821#toc
Repository:
rL LLVM
rnk accepted this revision.
rnk added a comment.
Yep, looks good. :)
https://reviews.llvm.org/D40276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
Reid, are you happy with this too?
In https://reviews.llvm.org/D40276#931502, @pasko wrote:
> Instrumenting the function entry post-inlining, without function exit, and
> with no parameters is exactly what we need. The
> `__cyg_profile_func_enter_bare` sounds good to me
mattcary added a comment.
It looks like there also has to be a change to
llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp?
Index: lib/Transforms/Utils/EntryExitInstrumenter.cpp
=
- lib/Transforms/Utils/EntryExitInstrumenter.cpp
pasko accepted this revision.
pasko added a comment.
This revision is now accepted and ready to land.
Instrumenting the function entry post-inlining, without function exit, and with
no parameters is exactly what we need. The `__cyg_profile_func_enter_bare`
sounds good to me as a name. Thank
hans created this revision.
This is an instrumentation flag, similar to -finstrument-functions, but it only
inserts calls on function entry, the calls are inserted post-inlining, and they
don't take any arugments.
This is intended for users who want to instrument function entry with minimal
