This revision was automatically updated to reflect the committed changes.
Closed by commit rL318874: [demangler] Support for abi_tag attribute (authored
by epilk).
Changed prior to commit:
https://reviews.llvm.org/D40279?vs=123787=124003#toc
Repository:
rL LLVM
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D40279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
erik.pilkington marked 5 inline comments as done.
erik.pilkington added inline comments.
Comment at: src/cxa_demangle.cpp:10
+// FIXME: (possibly) incomplete list of features that clang mangles that this
+// file does not yet support:
EricWF wrote:
> Awesome
erik.pilkington updated this revision to Diff 123787.
erik.pilkington added a comment.
In this new patch:
- Update the comment BNF to show the new attribute, fix comment formatting
- Move call to parse_abi_tag_seq() from parse_unqualified_name() to
parse_operator_name() to more closely model
EricWF added inline comments.
Comment at: src/cxa_demangle.cpp:10
+// FIXME: (possibly) incomplete list of features that clang mangles that this
+// file does not yet support:
Awesome comment!
If your awesomeness knows no bound, I would love to add
erik.pilkington created this revision.
This patch adds demangling support for `__attribute__((abi_tag))`. I.e, the
following function: `__attribute__((abi_tag("foo"))) void f() {}` mangles to
`_Z1fB3foov`, and now demangles to `f[abi:foo]()` (this syntax is the same as
GCC's demangler). This
