This revision was automatically updated to reflect the committed changes.
Closed by commit rL318755: [MINGW] normalize WIN32 macros (authored by martell).
Changed prior to commit:
https://reviews.llvm.org/D40285?vs=123751=123755#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40285
mstorsjo accepted this revision.
mstorsjo added a comment.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D40285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell added a comment.
@mstorsjo can you confirm this new order looks good to you?
Repository:
rL LLVM
https://reviews.llvm.org/D40285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
martell updated this revision to Diff 123751.
martell added a comment.
reorder test checks
Repository:
rL LLVM
https://reviews.llvm.org/D40285
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets.h
lib/Basic/Targets/AArch64.cpp
lib/Basic/Targets/AArch64.h
lib/Basic/Targets/ARM.cpp
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/Preprocessor/predefined-macros.c:200
+// CHECK-X86-WIN: #define _WIN32 1
+// CHECK-X86-WIN-NOT: #define _WIN64 1
+// CHECK-X86-WIN-NOT: #define
martell updated this revision to Diff 123747.
martell edited the summary of this revision.
martell added a comment.
[MINGW] normalize WIN32 macros
Repository:
rL LLVM
https://reviews.llvm.org/D40285
Files:
lib/Basic/Targets.cpp
lib/Basic/Targets.h
lib/Basic/Targets/AArch64.cpp