nsz added a comment.
In https://reviews.llvm.org/D40673#973638, @efriedma wrote:
> > as this patch is committed clang is broken (cannot use glibc headers)
>
> This patch was supposed to *fix* compatibility with the glibc headers. If it
> doesn't, we should clearly revert it... but we need to fi
efriedma added a comment.
> as this patch is committed clang is broken (cannot use glibc headers)
This patch was supposed to *fix* compatibility with the glibc headers. If it
doesn't, we should clearly revert it... but we need to figure out what we need
to do to be compatible first.
From what
nsz added a comment.
also note that there is less than 3 weeks until glibc-2.27 is released, if the
headers need a fix for clang then say so quickly
i opened https://sourceware.org/bugzilla/show_bug.cgi?id=22700 but it needs
attention from some clang developers,
in particular there is no way to
nsz added a comment.
if clang wants to provide _Float128 then the f128 constant suffix (specified by
TS18661-3) and __builtin_inff128, __builtin_nanf128, __builtin_nansf128,
__builtin_huge_valf128 (gcc builtins required by math.h) need to be supported
too.
as this patch is committed clang is b
jgreenhalgh added a comment.
If this patch unconditionally defines _Float128, then I think it will conflict
with the typedef for _Float128 for IEEE754 128-bit long double systems in glibc:
/* The type _Float128 exists only since GCC 7.0. */
# if !__GNUC_PREREQ (7, 0) || defined __cplusplus
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319703: Add _Float128 as alias to __float128 to enable
compilations on Fedora27/glibc2… (authored by erichkeane).
Repository:
rC Clang
https://reviews.llvm.org/D40673
Files:
include/clang/Basic/Toke
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
Looks good to me.
Repository:
rL LLVM
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
mibintc marked 3 inline comments as done.
mibintc added a comment.
added inline replies to Eli and Hubert
Comment at: lib/Frontend/InitPreprocessor.cpp:817
DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L");
+ DefineFloatMacros(Builder, "FLT128", &TI.getFloa
mibintc updated this revision to Diff 125378.
mibintc added a subscriber: eli.friedman.
mibintc added a comment.
I responded to comments from @eli.friedman and @hubert.reinterpretcast : I
added FIXME comment regarding the "Q" suffix on the float 128 literals (gcc
uses https://reviews.llvm.org/F
hubert.reinterpretcast added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:817
DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L");
+ DefineFloatMacros(Builder, "FLT128", &TI.getFloat128Format(), "Q");
+
GCC //does// define the
mibintc updated this revision to Diff 125211.
mibintc added a comment.
I changed the patch to enable _Float128 only as keyword in mode "nocxx" - this
is the same mode being used by _Bool. I changed the test from .cpp to .c; I run
check-all and saw only the usual suspects fail. What do you think
mibintc abandoned this revision.
mibintc added a comment.
Thanks for all your reviews
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast added inline comments.
Comment at: test/Sema/_Float128.cpp:1
+// RUN: %clang_cc1 -verify -std=gnu++11 %s
+// RUN: %clang_cc1 -verify -std=c++11 %s
GCC documents that it does not support `_Float128` in C++ mode, and I think
their decision m
efriedma added a comment.
> _Float128 is only *sometimes* the same type as __float128.
But we don't have hppa or IA-64 backends, so we're fine for now, I think. :)
Comment at: lib/Frontend/InitPreprocessor.cpp:817
DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat()
rsmith added a comment.
Per https://gcc.gnu.org/onlinedocs/gcc/Floating-Types.html, this doesn't appear
to be correct: `_Float128` is only *sometimes* the same type as `__float128`.
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-c
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
LGTM for the CUDA test changes.
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
mibintc created this revision.
mibintc added a project: clang.
Fedora27 is using a new version of glibc that refers to the _Float128 type.
This patch adds that name as an alias to __float128. I also added some
predefined macro values for the digits, mantissa, epilon, etc (FloatMacros).
For the
17 matches
Mail list logo
