[PATCH] D41318: Start setting dso_local in clang

espindola closed this revision. espindola added a comment. r324107 https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41318: Start setting dso_local in clang

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41318: Start setting dso_local in clang

espindola updated this revision to Diff 132282. espindola added a comment. Handle ppc. https://reviews.llvm.org/D41318 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGenModule.h

Re: [PATCH] D41318: Start setting dso_local in clang

Sean Fertile via Phabricator writes: > sfertile added inline comments. > > > > Comment at: clang/lib/CodeGen/CodeGenModule.cpp:750 > + // If we can use a plt entry as the symbol address we can assume it > + // is local. > + if (isa(D) &&

[PATCH] D41318: Start setting dso_local in clang

sfertile added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:750 + // If we can use a plt entry as the symbol address we can assume it + // is local. + if (isa(D) && !CGOpts.NoPLT) I don't think this is the case. I think this would break

[PATCH] D41318: Start setting dso_local in clang

sfertile added a comment. Sorry, I missed that you wanted this reviewed again, I'll make sure to review it today. https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41318: Start setting dso_local in clang

espindola updated this revision to Diff 131878. espindola added a comment. Rebased. Ping https://reviews.llvm.org/D41318 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D41318: Start setting dso_local in clang

espindola updated this revision to Diff 130351. espindola added a comment. Herald added subscribers: niosHD, sabuasal, apazos, jordy.potman.lists, simoncook, johnrusso, rbar, asb. All tests have been updated. A few missing cases in c++ codegen are handled. We now use

[PATCH] D41318: Start setting dso_local in clang

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, sorry for the holiday delay. https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D41318: Start setting dso_local in clang

Ping. Is this direction OK? Should a put the time to update the existing tests to account for dso_local? I do volunteer to implement the rest of ELF, COFF and MachO once this is in. Cheers, Rafael Rafael Avila de Espindola writes: > Reid Kleckner via Phabricator

Re: [PATCH] D41318: Start setting dso_local in clang

Reid Kleckner via Phabricator writes: > rnk added inline comments. > > > > Comment at: lib/CodeGen/CodeGenModule.cpp:690-692 > + // Only handle ELF for now. > + if (!CGM.getTriple().isOSBinFormatELF()) > +return false; > >

[PATCH] D41318: Start setting dso_local in clang

rnk added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:690-692 + // Only handle ELF for now. + if (!CGM.getTriple().isOSBinFormatELF()) +return false; Handling COFF here is probably trivial. Everything is dso_local unless it's dllimport.

[PATCH] D41318: Start setting dso_local in clang

rafael created this revision. rafael added reviewers: rnk, rsmith. This starts adding dso_local to clang. The hope is to eventually have TargetMachine::shouldAssumeDsoLocal go away. My objective for now is to move enough of it to clang to remove the need for the TargetMachine one to handle PIE