sammccall marked 2 inline comments as done.
sammccall added a comment.
Context here, this patch is over a year old and predates the work on
heuristically picking a compile command from another file in the CDB.
I don't think anyone has concrete plans to revive this, the heuristics work
well
klimek added inline comments.
Comment at: clangd/IncludeScanner.cpp:75
+ bool WasEmpty = Queue.empty();
+ for (const auto : Cmds) {
+QueueEntry E(Cmd, VFS);
Usually I'd try to not lock a loop, as a large number of compile commands now
blocks other
nridge added a comment.
Herald added subscribers: jfb, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
Are there are plans to move forward with this sort of an include scanning
approach?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgorny, klimek.
Not enabled because we need a threadsafe way to change VFS working directories.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41911
Files:
